[ 
https://issues.apache.org/jira/browse/HDFS-14616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16883408#comment-16883408
 ] 

Wei-Chiu Chuang commented on HDFS-14616:
----------------------------------------

If it just adds a log message you don't need a test case. 
Also note that RoundRobinVolumeChoosingPolicy uses slf4j logger. So you can 
consider using parameterized logging as well.

> Add the warn log when the volume available space isn't enough
> -------------------------------------------------------------
>
>                 Key: HDFS-14616
>                 URL: https://issues.apache.org/jira/browse/HDFS-14616
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs
>    Affects Versions: 2.7.2
>            Reporter: liying
>            Priority: Minor
>             Fix For: 2.7.3
>
>         Attachments: HDFS-14616-v1.patch, HDFS-14616-v2.patch
>
>
> In the hadoop2 version, there is no warning log that the disk is not 
> available when using the disk. Therefore, the datanode log cannot be used to 
> check if the disk is not available ata certain time or for other problems.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to