[
https://issues.apache.org/jira/browse/HDFS-11687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16883523#comment-16883523
]
Daryn Sharp commented on HDFS-11687:
------------------------------------
Admittedly very late to comment but this is a bad patch. Not for the intent
but the unintended consequences. The intent was to expose if the NN is using
a key provider but also changed getTrashRoot to catch/log errors. Here's the
problem: Before trashing paths one must determine if the path is in an EZ. If
yes, the path cannot be renamed to the user's trash and must (enforced by NN)
be renamed to an EZ local trash dir. This patch catches/logs/ignores the
attempt to determine if the path is in an EZ so as a consequence, the client
will attempt to rename an EZ path to the user's trash and obviously fail.
We need to avoid the catch/log anti-pattern and haphazardly changing unrelated
code to ignore exceptions. Perhaps a once in a million chance to fail and will
in all likelihood succeed if retried, but it's bothersome when ramping up EZs
at scale...
> Add new public encryption APIs required by Hive
> -----------------------------------------------
>
> Key: HDFS-11687
> URL: https://issues.apache.org/jira/browse/HDFS-11687
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: encryption
> Affects Versions: 2.6.5
> Reporter: Andrew Wang
> Assignee: Lei (Eddy) Xu
> Priority: Major
> Fix For: 2.9.0, 3.0.0-alpha4
>
> Attachments: HDFS-11687.00.patch, HDFS-11687.01.patch,
> HDFS-11687.02.patch, HDFS-11687.03.patch
>
>
> As discovered on HADOOP-14333, Hive is using reflection to get a DFSClient
> for its encryption shim. We should provide proper public APIs for getting
> this information.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
