[
https://issues.apache.org/jira/browse/HDFS-2496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13134752#comment-13134752
]
Tsz Wo (Nicholas), SZE commented on HDFS-2496:
----------------------------------------------
- The two local variables below hide the fields. It looks like a bug.
{code}
+ Block[] blocks = new Block[blocktargetlist.size()];
+ DatanodeInfo[][] targets = new DatanodeInfo[blocks.length][];
{code}
- move the utility methods in DatanodeCommandHelper to DatanodeCommandWritable
and then remove DatanodeCommandHelper. BTW, both convert methods should be
static.
BTW, let's create an umbrella jira for all the similar changes.
> Separate datatypes for DatanodeProtocol
> ---------------------------------------
>
> Key: HDFS-2496
> URL: https://issues.apache.org/jira/browse/HDFS-2496
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Attachments: HDFS-2496.txt, HDFS-2496.txt
>
>
> This jira separates for DatanodeProtocol the wire types from the types used
> by the client and server, similar to HDFS-2181.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
