[
https://issues.apache.org/jira/browse/HDDS-1800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Elek, Marton updated HDDS-1800:
-------------------------------
Description:
h2. What changes were proposed in this pull request?
h2.
Fix:
1. author check fails when no violations are found
2. author check violations are duplicated in the output
Eg. https://ci.anzix.net/job/ozone-nightly/173/consoleText says that:
{code:java}
The following tests are FAILED:
[author]: author check is failed
(https://ci.anzix.net/job/ozone-nightly/173//artifact/build/author.out/*view*/){code}
but no actual `@author` tags were found:
```
$ curl -s
'https://ci.anzix.net/job/ozone-nightly/173//artifact/build/author.out/*view*/'
| wc
0 0 0
```
h2. How was this patch tested?
{code}
$ bash -o pipefail -c 'hadoop-ozone/dev-support/checks/author.sh | tee
build/author.out'; echo $?
0
$ wc build/author.out
0 0 0 build/author.out
$ echo '// @author Tolkien' >>
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/BucketManager.java
$ bash -o pipefail -c 'hadoop-ozone/dev-support/checks/author.sh | tee
build/author.out'; echo $?
./hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/BucketManager.java://
@author Tolkien
1
$ wc build/author.out
1 3 108 build/author.out
{code}
was:
## What changes were proposed in this pull request?
Fix:
1. author check fails when no violations are found
2. author check violations are duplicated in the output
Eg. https://ci.anzix.net/job/ozone-nightly/173/consoleText says that:
{code:java}
The following tests are FAILED:
[author]: author check is failed
(https://ci.anzix.net/job/ozone-nightly/173//artifact/build/author.out/*view*/){code}
but no actual `@author` tags were found:
```
$ curl -s
'https://ci.anzix.net/job/ozone-nightly/173//artifact/build/author.out/*view*/'
| wc
0 0 0
```
## How was this patch tested?
{code}
$ bash -o pipefail -c 'hadoop-ozone/dev-support/checks/author.sh | tee
build/author.out'; echo $?
0
$ wc build/author.out
0 0 0 build/author.out
$ echo '// @author Tolkien' >>
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/BucketManager.java
$ bash -o pipefail -c 'hadoop-ozone/dev-support/checks/author.sh | tee
build/author.out'; echo $?
./hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/BucketManager.java://
@author Tolkien
1
$ wc build/author.out
1 3 108 build/author.out
{code}
> Result of author check is inverted
> ----------------------------------
>
> Key: HDDS-1800
> URL: https://issues.apache.org/jira/browse/HDDS-1800
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Doroszlai, Attila
> Assignee: Doroszlai, Attila
> Priority: Major
>
> h2. What changes were proposed in this pull request?
> h2.
> Fix:
> 1. author check fails when no violations are found
> 2. author check violations are duplicated in the output
> Eg. https://ci.anzix.net/job/ozone-nightly/173/consoleText says that:
> {code:java}
> The following tests are FAILED:
> [author]: author check is failed
> (https://ci.anzix.net/job/ozone-nightly/173//artifact/build/author.out/*view*/){code}
> but no actual `@author` tags were found:
> ```
> $ curl -s
> 'https://ci.anzix.net/job/ozone-nightly/173//artifact/build/author.out/*view*/'
> | wc
> 0 0 0
> ```
> h2. How was this patch tested?
> {code}
> $ bash -o pipefail -c 'hadoop-ozone/dev-support/checks/author.sh | tee
> build/author.out'; echo $?
> 0
> $ wc build/author.out
> 0 0 0 build/author.out
> $ echo '// @author Tolkien' >>
> hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/BucketManager.java
> $ bash -o pipefail -c 'hadoop-ozone/dev-support/checks/author.sh | tee
> build/author.out'; echo $?
> ./hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/BucketManager.java://
> @author Tolkien
> 1
> $ wc build/author.out
> 1 3 108 build/author.out
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
