[
https://issues.apache.org/jira/browse/HDDS-1800?focusedWorklogId=276808&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-276808
]
ASF GitHub Bot logged work on HDDS-1800:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Jul/19 16:02
Start Date: 15/Jul/19 16:02
Worklog Time Spent: 10m
Work Description: elek commented on pull request #1092: HDDS-1800. Result
of author check is inverted
URL: https://github.com/apache/hadoop/pull/1092
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 276808)
Time Spent: 10m
Remaining Estimate: 0h
> Result of author check is inverted
> ----------------------------------
>
> Key: HDDS-1800
> URL: https://issues.apache.org/jira/browse/HDDS-1800
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Doroszlai, Attila
> Assignee: Doroszlai, Attila
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> h2. What changes were proposed in this pull request?
> h2.
> Fix:
> 1. author check fails when no violations are found
> 2. author check violations are duplicated in the output
> Eg. https://ci.anzix.net/job/ozone-nightly/173/consoleText says that:
> {code:java}
> The following tests are FAILED:
> [author]: author check is failed
> (https://ci.anzix.net/job/ozone-nightly/173//artifact/build/author.out/*view*/){code}
> but no actual `@author` tags were found:
> {code}
> $ curl -s
> 'https://ci.anzix.net/job/ozone-nightly/173//artifact/build/author.out/*view*/'
> | wc
> 0 0 0
> {code}
> h2. How was this patch tested?
> {code}
> $ bash -o pipefail -c 'hadoop-ozone/dev-support/checks/author.sh | tee
> build/author.out'; echo $?
> 0
> $ wc build/author.out
> 0 0 0 build/author.out
> $ echo '// @author Tolkien' >>
> hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/BucketManager.java
> $ bash -o pipefail -c 'hadoop-ozone/dev-support/checks/author.sh | tee
> build/author.out'; echo $?
> ./hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/BucketManager.java://
> @author Tolkien
> 1
> $ wc build/author.out
> 1 3 108 build/author.out
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
