[
https://issues.apache.org/jira/browse/HDDS-1761?focusedWorklogId=277091&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-277091
]
ASF GitHub Bot logged work on HDDS-1761:
----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Jul/19 00:53
Start Date: 16/Jul/19 00:53
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #1052:
HDDS-1761. Fix class hierarchy for KeyRequest and FileRequest classes.
URL: https://github.com/apache/hadoop/pull/1052
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 277091)
Time Spent: 40m (was: 0.5h)
> Fix class hierarchy for KeyRequest and FileRequest classes.
> -----------------------------------------------------------
>
> Key: HDDS-1761
> URL: https://issues.apache.org/jira/browse/HDDS-1761
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.5.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The patch looks mostly fine to me. A few minor comments. -and one type error
> that needs to be fixed.-
> I would like to see the class hierarchy refactored in a follow up patch.
> {{OMFileCreateRequest}}should not extend {{OMKeyCreateRequest}}. Instead they
> should both extend an abstract class that encapsulates the common
> functionality.
> Generally deriving from _concrete_ classes is a bad idea.
>
> This Jira is created based on [~arp] comment during review of HDDS-1731
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
