[
https://issues.apache.org/jira/browse/HDDS-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16885735#comment-16885735
]
Hudson commented on HDDS-1761:
------------------------------
FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #16920 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/16920/])
HDDS-1761. Fix class hierarchy for KeyRequest and FileRequest classes. (github:
rev 585f4d5c6405c8f85c6ef11a43a14302c261be11)
* (edit)
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCreateRequest.java
* (edit)
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyDeleteRequest.java
* (edit)
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyRenameRequest.java
* (edit)
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMDirectoryCreateRequest.java
* (edit)
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileCreateRequest.java
* (edit)
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMAllocateBlockRequest.java
* (edit)
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCommitRequest.java
* (edit)
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyRequest.java
> Fix class hierarchy for KeyRequest and FileRequest classes.
> -----------------------------------------------------------
>
> Key: HDDS-1761
> URL: https://issues.apache.org/jira/browse/HDDS-1761
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.5.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The patch looks mostly fine to me. A few minor comments. -and one type error
> that needs to be fixed.-
> I would like to see the class hierarchy refactored in a follow up patch.
> {{OMFileCreateRequest}}should not extend {{OMKeyCreateRequest}}. Instead they
> should both extend an abstract class that encapsulates the common
> functionality.
> Generally deriving from _concrete_ classes is a bad idea.
>
> This Jira is created based on [~arp] comment during review of HDDS-1731
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
