[
https://issues.apache.org/jira/browse/HDDS-1767?focusedWorklogId=277499&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-277499
]
ASF GitHub Bot logged work on HDDS-1767:
----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Jul/19 13:32
Start Date: 16/Jul/19 13:32
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on issue #1087: HDDS-1767:
ContainerStateMachine should have its own executors for executing
applyTransaction calls
URL: https://github.com/apache/hadoop/pull/1087#issuecomment-511817459
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| 0 | reexec | 35 | Docker mode activated. |
||| _ Prechecks _ |
| +1 | dupname | 0 | No case conflicting files found. |
| +1 | @author | 0 | The patch does not contain any @author tags. |
| -1 | test4tests | 0 | The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch. |
||| _ trunk Compile Tests _ |
| +1 | mvninstall | 463 | trunk passed |
| +1 | compile | 251 | trunk passed |
| +1 | checkstyle | 73 | trunk passed |
| +1 | mvnsite | 0 | trunk passed |
| +1 | shadedclient | 884 | branch has no errors when building and testing
our client artifacts. |
| +1 | javadoc | 156 | trunk passed |
| 0 | spotbugs | 317 | Used deprecated FindBugs config; considering
switching to SpotBugs. |
| +1 | findbugs | 507 | trunk passed |
||| _ Patch Compile Tests _ |
| +1 | mvninstall | 473 | the patch passed |
| +1 | compile | 255 | the patch passed |
| +1 | javac | 255 | the patch passed |
| +1 | checkstyle | 65 | the patch passed |
| +1 | mvnsite | 0 | the patch passed |
| +1 | whitespace | 0 | The patch has no whitespace issues. |
| +1 | shadedclient | 647 | patch has no errors when building and testing
our client artifacts. |
| +1 | javadoc | 156 | the patch passed |
| +1 | findbugs | 522 | the patch passed |
||| _ Other Tests _ |
| +1 | unit | 288 | hadoop-hdds in the patch passed. |
| -1 | unit | 1936 | hadoop-ozone in the patch failed. |
| +1 | asflicense | 51 | The patch does not generate ASF License warnings. |
| | | 6897 | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests |
hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient |
| | hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis |
| | hadoop.ozone.client.rpc.TestOzoneAtRestEncryption |
| | hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=18.09.7 Server=18.09.7 base:
https://builds.apache.org/job/hadoop-multibranch/job/PR-1087/3/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/1087 |
| JIRA Issue | HDDS-1767 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux 55fe32de3656 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24
10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 1502e6a |
| Default Java | 1.8.0_212 |
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1087/3/artifact/out/patch-unit-hadoop-ozone.txt
|
| Test Results |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1087/3/testReport/ |
| Max. process+thread count | 4883 (vs. ulimit of 5500) |
| modules | C: hadoop-hdds/container-service U:
hadoop-hdds/container-service |
| Console output |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1087/3/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
| Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 277499)
Time Spent: 20m (was: 10m)
> ContainerStateMachine should have its own executors for executing
> applyTransaction calls
> ----------------------------------------------------------------------------------------
>
> Key: HDDS-1767
> URL: https://issues.apache.org/jira/browse/HDDS-1767
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Lokesh Jain
> Assignee: Lokesh Jain
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Currently ContainerStateMachine uses the executors provided by
> XceiverServerRatis for executing applyTransaction calls. This would result in
> two or more ContainerStateMachine to share the same set of executors. Delay
> or load in one ContainerStateMachine would adversely affect the performance
> of other state machines in such a case. It is better to have separate set of
> executors for each ContainerStateMachine.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
