[
https://issues.apache.org/jira/browse/HDFS-12979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16886346#comment-16886346
]
Erik Krogen commented on HDFS-12979:
------------------------------------
The logic in v13 patch looks clean to me; the use of the HTTP context attribute
is much nicer than the static variable. I have just a few small nits:
* Before casting {{recentImageCheckEnabledObj}} to a boolean on L524, should we
first confirm that it is indeed a boolean? Otherwise, an incorrect value sent
by a caller could throw a {{ClassCastException}} here.
* {{MiniDFSCluster}} L988, can we use the constant instead of writing out the
string
* {{TestCheckpoint}} L2741 and 2472 you can combine into one line
* {{TestCheckpoint}} L2473 you have a typo "threshod"
* {{TestStandbyCheckpoints}} L270, it says that the observer "pulls" the image,
but really the standby pushes it, can we update this language?
> StandbyNode should upload FsImage to ObserverNode after checkpointing.
> ----------------------------------------------------------------------
>
> Key: HDFS-12979
> URL: https://issues.apache.org/jira/browse/HDFS-12979
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs
> Reporter: Konstantin Shvachko
> Assignee: Chen Liang
> Priority: Major
> Attachments: HDFS-12979.001.patch, HDFS-12979.002.patch,
> HDFS-12979.003.patch, HDFS-12979.004.patch, HDFS-12979.005.patch,
> HDFS-12979.006.patch, HDFS-12979.007.patch, HDFS-12979.008.patch,
> HDFS-12979.009.patch, HDFS-12979.010.patch, HDFS-12979.011.patch,
> HDFS-12979.012.patch, HDFS-12979.013.patch
>
>
> ObserverNode does not create checkpoints. So it's fsimage file can get very
> old making bootstrap of ObserverNode too long. A StandbyNode should copy
> latest fsimage to ObserverNode(s) along with ANN.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
