[
https://issues.apache.org/jira/browse/HDDS-1686?focusedWorklogId=277882&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-277882
]
ASF GitHub Bot logged work on HDDS-1686:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Jul/19 00:28
Start Date: 17/Jul/19 00:28
Worklog Time Spent: 10m
Work Description: xiaoyuyao commented on pull request #966: HDDS-1686.
Remove check to get from openKeyTable in acl implementatio…
URL: https://github.com/apache/hadoop/pull/966#discussion_r304178181
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java
##########
@@ -1370,17 +1370,10 @@ public boolean addAcl(OzoneObj obj, OzoneAcl acl)
throws IOException {
validateBucket(volume, bucket);
String objectKey = metadataManager.getOzoneKey(volume, bucket, keyName);
OmKeyInfo keyInfo = metadataManager.getKeyTable().get(objectKey);
- Table keyTable;
if (keyInfo == null) {
Review comment:
I don't have specific use case for setting acl for uncommitted key as it is
only visible to the client with lease. Based on that, I think it is OK to skip
check the openKeyTable for acl.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 277882)
Time Spent: 1h (was: 50m)
> Remove check to get from openKeyTable in acl implementation for Keys
> --------------------------------------------------------------------
>
> Key: HDDS-1686
> URL: https://issues.apache.org/jira/browse/HDDS-1686
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Remove the checks for openKeyTable in acl Implementation for Keys.
> As entries in openKeyTable are appended with clientID, so the entry will not
> be found in openKey table 100% of the time. We can save 1 DB read in this way.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
