[
https://issues.apache.org/jira/browse/HDDS-1713?focusedWorklogId=278993&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-278993
]
ASF GitHub Bot logged work on HDDS-1713:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Jul/19 13:51
Start Date: 18/Jul/19 13:51
Worklog Time Spent: 10m
Work Description: adoroszlai commented on pull request #1112: HDDS-1713.
ReplicationManager fail to find proper node topology based…
URL: https://github.com/apache/hadoop/pull/1112#discussion_r304925218
##########
File path:
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/placement/algorithms/TestSCMContainerPlacementRackAware.java
##########
@@ -137,10 +137,6 @@ public void chooseNodeWithNoExcludedNodes() throws
SCMException {
datanodeDetails.get(2)));
Assert.assertFalse(cluster.isSameParent(datanodeDetails.get(1),
datanodeDetails.get(2)));
- Assert.assertFalse(cluster.isSameParent(datanodeDetails.get(0),
- datanodeDetails.get(3)));
- Assert.assertFalse(cluster.isSameParent(datanodeDetails.get(2),
- datanodeDetails.get(3)));
Review comment:
I guess you are removing this assertion because it makes the test flaky
(node 2 and 3 may or may not be in the same rack, the only restriction is that
they are in different one than nodes 0 and 1). If so, please also remove
similar assertion from `testFallback`:
https://github.com/apache/hadoop/blob/f9266ccc4d592681cc8227a147799d3a08623493/hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/placement/algorithms/TestSCMContainerPlacementRackAware.java#L200-L201
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 278993)
Time Spent: 2h 40m (was: 2.5h)
> ReplicationManager fail to find proper node topology based on Datanode
> details from heartbeat
> ---------------------------------------------------------------------------------------------
>
> Key: HDDS-1713
> URL: https://issues.apache.org/jira/browse/HDDS-1713
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Xiaoyu Yao
> Assignee: Sammi Chen
> Priority: Blocker
> Labels: pull-request-available
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> DN does not have the topology info included in its heartbeat message for
> container report/pipeline report.
> SCM is where the topology information is available. During the processing of
> heartbeat, we should not rely on the datanodedetails from report to choose
> datanodes for close container. Otherwise, all the datanode locations of
> existing container replicas will fallback to /default-rack.
>
> The fix is to retrieve the corresponding datanode locations from scm
> nodemanager, which has authoritative network topology information.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
