[
https://issues.apache.org/jira/browse/HDDS-1682?focusedWorklogId=279758&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-279758
]
ASF GitHub Bot logged work on HDDS-1682:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Jul/19 13:51
Start Date: 19/Jul/19 13:51
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on issue #962: HDDS-1682.
TestEventWatcher.testMetrics is flaky
URL: https://github.com/apache/hadoop/pull/962#issuecomment-513236492
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| 0 | reexec | 36 | Docker mode activated. |
||| _ Prechecks _ |
| +1 | dupname | 1 | No case conflicting files found. |
| +1 | @author | 0 | The patch does not contain any @author tags. |
| +1 | test4tests | 0 | The patch appears to include 1 new or modified test
files. |
||| _ trunk Compile Tests _ |
| +1 | mvninstall | 469 | trunk passed |
| +1 | compile | 253 | trunk passed |
| +1 | checkstyle | 63 | trunk passed |
| +1 | mvnsite | 0 | trunk passed |
| +1 | shadedclient | 787 | branch has no errors when building and testing
our client artifacts. |
| +1 | javadoc | 147 | trunk passed |
| 0 | spotbugs | 302 | Used deprecated FindBugs config; considering
switching to SpotBugs. |
| +1 | findbugs | 488 | trunk passed |
||| _ Patch Compile Tests _ |
| +1 | mvninstall | 433 | the patch passed |
| +1 | compile | 256 | the patch passed |
| +1 | javac | 256 | the patch passed |
| +1 | checkstyle | 80 | the patch passed |
| +1 | mvnsite | 0 | the patch passed |
| +1 | whitespace | 0 | The patch has no whitespace issues. |
| +1 | shadedclient | 661 | patch has no errors when building and testing
our client artifacts. |
| +1 | javadoc | 154 | the patch passed |
| +1 | findbugs | 513 | the patch passed |
||| _ Other Tests _ |
| -1 | unit | 278 | hadoop-hdds in the patch failed. |
| -1 | unit | 1498 | hadoop-ozone in the patch failed. |
| +1 | asflicense | 40 | The patch does not generate ASF License warnings. |
| | | 6314 | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests |
hadoop.hdds.scm.container.placement.algorithms.TestSCMContainerPlacementRackAware
|
| | hadoop.hdds.scm.block.TestBlockManager |
| | hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures |
| | hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient |
| | hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException |
| | hadoop.ozone.client.rpc.TestOzoneRpcClient |
| | hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures |
| | hadoop.ozone.container.server.TestSecureContainerServer |
| | hadoop.ozone.container.ozoneimpl.TestSecureOzoneContainer |
| | hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis |
| | hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory |
| | hadoop.ozone.client.rpc.TestSecureOzoneRpcClient |
| | hadoop.ozone.client.rpc.TestFailureHandlingByClient |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=18.09.8 Server=18.09.8 base:
https://builds.apache.org/job/hadoop-multibranch/job/PR-962/2/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/962 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux f1116a5f31ca 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 4e66cb9 |
| Default Java | 1.8.0_212 |
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-962/2/artifact/out/patch-unit-hadoop-hdds.txt
|
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-962/2/artifact/out/patch-unit-hadoop-ozone.txt
|
| Test Results |
https://builds.apache.org/job/hadoop-multibranch/job/PR-962/2/testReport/ |
| Max. process+thread count | 5050 (vs. ulimit of 5500) |
| modules | C: hadoop-hdds/framework U: hadoop-hdds/framework |
| Console output |
https://builds.apache.org/job/hadoop-multibranch/job/PR-962/2/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
| Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 279758)
Time Spent: 0.5h (was: 20m)
> TestEventWatcher.testMetrics is flaky
> -------------------------------------
>
> Key: HDDS-1682
> URL: https://issues.apache.org/jira/browse/HDDS-1682
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: test
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> TestEventWatcher is intermittent. (Failed twice out of 44 executions).
> Error is:
> {code}
> Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 7.764 s <<<
> FAILURE! - in org.apache.hadoop.hdds.server.events.TestEventWatcher
> testMetrics(org.apache.hadoop.hdds.server.events.TestEventWatcher) Time
> elapsed: 2.384 s <<< FAILURE!
> java.lang.AssertionError: expected:<2> but was:<3>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:743)
> at org.junit.Assert.assertEquals(Assert.java:118)
> at org.junit.Assert.assertEquals(Assert.java:555)
> at org.junit.Assert.assertEquals(Assert.java:542)
> at
> org.apache.hadoop.hdds.server.events.TestEventWatcher.testMetrics(TestEventWatcher.java:197)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> at
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159)
> at
> org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:384)
> at
> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:345)
> at
> org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:126)
> at
> org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:418)
> {code}
> In the test we do the following:
> 1. fire start-event1
> 2. fire start-event2
> 3. fire start-event3
> 4. fire end-event1
> 5. wait
> Usually the event2 and event3 are timed out and event1 is completed but in
> case of an accidental time between 3 and 4 (in fact between 1 and 4) the
> event1 also can be timed out.
> I improved the unit test and fixed the metrics calculation (completed message
> should be incremented only if it's not yet timed out).
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
