[
https://issues.apache.org/jira/browse/HDDS-1795?focusedWorklogId=279935&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-279935
]
ASF GitHub Bot logged work on HDDS-1795:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Jul/19 20:00
Start Date: 19/Jul/19 20:00
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #1097:
HDDS-1795. Implement S3 Delete Bucket request to use Cache and DoubleBuffer.
URL: https://github.com/apache/hadoop/pull/1097#discussion_r305505474
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/s3/bucket/S3BucketDeleteRequest.java
##########
@@ -0,0 +1,193 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.ozone.om.request.s3.bucket;
+
+import java.io.IOException;
+import java.util.HashMap;
+import java.util.Map;
+
+import com.google.common.base.Optional;
+import com.google.common.base.Preconditions;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import org.apache.hadoop.ozone.OzoneConsts;
+import org.apache.hadoop.ozone.audit.OMAction;
+import org.apache.hadoop.ozone.om.OMMetadataManager;
+import org.apache.hadoop.ozone.om.OMMetrics;
+import org.apache.hadoop.ozone.om.OzoneManager;
+import org.apache.hadoop.ozone.om.exceptions.OMException;
+import org.apache.hadoop.ozone.om.request.volume.OMVolumeRequest;
+import org.apache.hadoop.ozone.om.response.OMClientResponse;
+import org.apache.hadoop.ozone.om.response.s3.bucket.S3BucketDeleteResponse;
+import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos;
+import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos
+ .OMRequest;
+import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos
+ .OMResponse;
+import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos
+ .S3DeleteBucketRequest;
+import org.apache.hadoop.ozone.security.acl.IAccessAuthorizer;
+import org.apache.hadoop.ozone.security.acl.OzoneObj;
+import org.apache.hadoop.utils.db.cache.CacheKey;
+import org.apache.hadoop.utils.db.cache.CacheValue;
+
+import static
org.apache.hadoop.ozone.om.lock.OzoneManagerLock.Resource.BUCKET_LOCK;
+import static
org.apache.hadoop.ozone.om.lock.OzoneManagerLock.Resource.S3_BUCKET_LOCK;
+
+/**
+ * Handle Create S3Bucket request.
+ */
+public class S3BucketDeleteRequest extends OMVolumeRequest {
+
+ private static final Logger LOG =
+ LoggerFactory.getLogger(S3BucketDeleteRequest.class);
+
+ public S3BucketDeleteRequest(OMRequest omRequest) {
+ super(omRequest);
+ }
+
+ public OMRequest preExecute(OzoneManager ozoneManager) throws IOException {
+ S3DeleteBucketRequest s3DeleteBucketRequest =
+ getOmRequest().getDeleteS3BucketRequest();
+ Preconditions.checkNotNull(s3DeleteBucketRequest);
+
+ // TODO: Do we need to enforce the bucket rules in this code path?
+ // https://docs.aws.amazon.com/AmazonS3/latest/dev/BucketRestrictions.html
+
+ // For now only checked the length.
+ int bucketLength = s3DeleteBucketRequest.getS3BucketName().length();
+ if (bucketLength < 3 || bucketLength >= 64) {
Review comment:
This is to give the error to the user, S3 does not accept bucket requests
with length less than 3 and greater than 64. This is to match AWS S3 behavior.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 279935)
Time Spent: 1h 40m (was: 1.5h)
> Implement S3 Delete Bucket request to use Cache and DoubleBuffer
> ----------------------------------------------------------------
>
> Key: HDDS-1795
> URL: https://issues.apache.org/jira/browse/HDDS-1795
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: Ozone Manager
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Implement S3 Bucket write requests to use OM Cache, double buffer.
>
> In this Jira will add the changes to implement S3 bucket operations, and
> HA/Non-HA will have a different code path, but once all requests are
> implemented will have a single code path.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
