[
https://issues.apache.org/jira/browse/HDDS-1816?focusedWorklogId=282234&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-282234
]
ASF GitHub Bot logged work on HDDS-1816:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Jul/19 18:58
Start Date: 24/Jul/19 18:58
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #1150:
HDDS-1816: ContainerStateMachine should limit number of pending apply
transactions
URL: https://github.com/apache/hadoop/pull/1150#discussion_r306971240
##########
File path:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/ContainerStateMachine.java
##########
@@ -175,6 +179,10 @@ public ContainerStateMachine(RaftGroupId gid,
ContainerDispatcher dispatcher,
final int numContainerOpExecutors = conf.getInt(
OzoneConfigKeys.DFS_CONTAINER_RATIS_NUM_CONTAINER_OP_EXECUTORS_KEY,
OzoneConfigKeys.DFS_CONTAINER_RATIS_NUM_CONTAINER_OP_EXECUTORS_DEFAULT);
+ int maxPendingApplyTransactions = conf.getInt(
+
ScmConfigKeys.DFS_CONTAINER_RATIS_STATEMACHINE_MAX_PENDING_APPLY_TRANSACTIONS,
+
ScmConfigKeys.DFS_CONTAINER_RATIS_STATEMACHINE_MAX_PENDING_APPLY_TRANSACTIONS_DEFAULT);
+ applyTransactionSemaphore = new Semaphore(maxPendingApplyTransactions);
Review comment:
Question: Here do we need fair setting, to follow the order?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 282234)
Time Spent: 40m (was: 0.5h)
> ContainerStateMachine should limit number of pending apply transactions
> -----------------------------------------------------------------------
>
> Key: HDDS-1816
> URL: https://issues.apache.org/jira/browse/HDDS-1816
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Lokesh Jain
> Assignee: Lokesh Jain
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> ContainerStateMachine should limit number of pending apply transactions in
> order to avoid excessive heap usage by the pending transactions.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
