[
https://issues.apache.org/jira/browse/HDDS-1830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16892225#comment-16892225
]
Siyao Meng commented on HDDS-1830:
----------------------------------
Thanks [~bharatviswa]. In a short discussion with [~arp] we further decided to
make isRunning atomic (though volatile I theory should already be fine but it
shouldn't hurt to use to atomic). Just posted a PR.
I'm not entirely sure about using try-catch bracket in stop() though. But I
think it is too much hassle to put throws
InterruptedException in every parent calls (and someone might want to catch it
eventually).
I ran TestOzoneManagerDoubleBufferWithOMResponse#testDoubleBuffer locally. It
is no longer stuck.
> OzoneManagerDoubleBuffer#stop should wait for daemon thread to die
> ------------------------------------------------------------------
>
> Key: HDDS-1830
> URL: https://issues.apache.org/jira/browse/HDDS-1830
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Hanisha Koneru
> Assignee: Siyao Meng
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Based on [~arp]'s comment on HDDS-1649, OzoneManagerDoubleBuffer#stop() calls
> interrupt() on daemon thread but not join(). The thread might still be
> running when the call returns.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
