[
https://issues.apache.org/jira/browse/HDDS-1830?focusedWorklogId=282322&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-282322
]
ASF GitHub Bot logged work on HDDS-1830:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Jul/19 22:15
Start Date: 24/Jul/19 22:15
Worklog Time Spent: 10m
Work Description: arp7 commented on pull request #1156: HDDS-1830
OzoneManagerDoubleBuffer#stop should wait for daemon thread to die
URL: https://github.com/apache/hadoop/pull/1156#discussion_r307044362
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerDoubleBuffer.java
##########
@@ -64,7 +65,7 @@
private final OMMetadataManager omMetadataManager;
private final AtomicLong flushedTransactionCount = new AtomicLong(0);
private final AtomicLong flushIterations = new AtomicLong(0);
- private volatile boolean isRunning;
+ private AtomicBoolean isRunning = new AtomicBoolean(true);
Review comment:
Let's also make it final.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 282322)
Time Spent: 20m (was: 10m)
> OzoneManagerDoubleBuffer#stop should wait for daemon thread to die
> ------------------------------------------------------------------
>
> Key: HDDS-1830
> URL: https://issues.apache.org/jira/browse/HDDS-1830
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Hanisha Koneru
> Assignee: Siyao Meng
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Based on [~arp]'s comment on HDDS-1649, OzoneManagerDoubleBuffer#stop() calls
> interrupt() on daemon thread but not join(). The thread might still be
> running when the call returns.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
