[ 
https://issues.apache.org/jira/browse/HDDS-1858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16892964#comment-16892964
 ] 

Siddharth Wagle edited comment on HDDS-1858 at 7/25/19 5:13 PM:
----------------------------------------------------------------

[~anu] That's was the reason for the change in the first patch, is the last 
argument is passed correctly [~xyao]?


was (Author: swagle):
[~anu] That's the reason for the change in the first patch, is last argument is 
passed correctly [~xyao]?

> mTLS support for Ozone is not correct
> -------------------------------------
>
>                 Key: HDDS-1858
>                 URL: https://issues.apache.org/jira/browse/HDDS-1858
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>            Reporter: Josh Elser
>            Assignee: Siddharth Wagle
>            Priority: Critical
>              Labels: newbie
>             Fix For: 0.4.1
>
>         Attachments: HDDS-1858.01.patch, HDDS-1858.02.patch
>
>
> Thanks to Josh for reporting that we have missing 'Not' in the if condition 
> check.
> {code}
> if (conf.isGrpcMutualTlsRequired()) {
>         return new GrpcTlsConfig(
>             null, null, conf.getTrustStoreFile(), false);
>       } else {
>         return new GrpcTlsConfig(conf.getClientPrivateKeyFile(),
>             conf.getClientCertChainFile(), conf.getTrustStoreFile(), true);
>       }
> {code}
> it should have been
> {code}
> if (!conf.isGrpcMutualTlsRequired()) {
>         return new GrpcTlsConfig(
>             null, null, conf.getTrustStoreFile(), false);
>       } else {
>         return new GrpcTlsConfig(conf.getClientPrivateKeyFile(),
>             conf.getClientCertChainFile(), conf.getTrustStoreFile(), true);
>       }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to