[
https://issues.apache.org/jira/browse/HDDS-1200?focusedWorklogId=283003&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-283003
]
ASF GitHub Bot logged work on HDDS-1200:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Jul/19 23:28
Start Date: 25/Jul/19 23:28
Worklog Time Spent: 10m
Work Description: anuengineer commented on pull request #1154:
[HDDS-1200] Add support for checksum verification in data scrubber
URL: https://github.com/apache/hadoop/pull/1154#discussion_r307537516
##########
File path:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueContainerCheck.java
##########
@@ -220,43 +229,66 @@ private void checkBlockDB() throws IOException {
throw new IOException(dbFileErrorMsg);
}
-
onDiskContainerData.setDbFile(dbFile);
try(ReferenceCountedDB db =
- BlockUtils.getDB(onDiskContainerData, checkConfig)) {
- iterateBlockDB(db);
- }
- }
+ BlockUtils.getDB(onDiskContainerData, checkConfig);
+ KeyValueBlockIterator kvIter = new KeyValueBlockIterator(containerID,
+ new File(onDiskContainerData.getContainerPath()))) {
Review comment:
Can you please run this in a profiler mode -- and make sure there are no
memory leaks in this code path. Nothing to do with your patch at all. Just that
we have found some issues here earlier. Just run it under something like
VisualVM and see if we release all memory when get out of the loop.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 283003)
Time Spent: 1.5h (was: 1h 20m)
> Ozone Data Scrubbing : Checksum verification for chunks
> -------------------------------------------------------
>
> Key: HDDS-1200
> URL: https://issues.apache.org/jira/browse/HDDS-1200
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Supratim Deka
> Assignee: Hrishikesh Gadre
> Priority: Critical
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Background scrubber should read each chunk and verify the checksum.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
