[
https://issues.apache.org/jira/browse/HDDS-1867?focusedWorklogId=283317&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-283317
]
ASF GitHub Bot logged work on HDDS-1867:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Jul/19 12:42
Start Date: 26/Jul/19 12:42
Worklog Time Spent: 10m
Work Description: adoroszlai commented on pull request #1172: HDDS-1867.
Invalid Prometheus metric name from JvmMetrics
URL: https://github.com/apache/hadoop/pull/1172
## What changes were proposed in this pull request?
Fix `invalid metric type` error introduced by using JVM Metrics. Instead of
adding replacement for space, replace all characters that cannot appear in
Prometheus metric names with `_`.
https://issues.apache.org/jira/browse/HDDS-1867
## How was this patch tested?
Verified in `ozoneperf` compose environment that `http://scm:9876/prom`
endpoint is UP, and no `invalid metric type` error appears in the log.
Added unit test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 283317)
Time Spent: 10m
Remaining Estimate: 0h
> Invalid Prometheus metric name from JvmMetrics
> ----------------------------------------------
>
> Key: HDDS-1867
> URL: https://issues.apache.org/jira/browse/HDDS-1867
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Doroszlai, Attila
> Assignee: Doroszlai, Attila
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {noformat}
> target=http://scm:9876/prom msg="append failed" err="invalid metric type
> \"_old _generation counter\""
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
