[ 
https://issues.apache.org/jira/browse/HDFS-14632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16894205#comment-16894205
 ] 

Wei-Chiu Chuang commented on HDFS-14632:
----------------------------------------

I think this is safe to cherry pick into lower branches. At least, 3.2 and 3.1.

> Reduce useless #getNumLiveDataNodes call in SafeModeMonitor
> -----------------------------------------------------------
>
>                 Key: HDFS-14632
>                 URL: https://issues.apache.org/jira/browse/HDFS-14632
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>    Affects Versions: 2.9.0
>            Reporter: He Xiaoqiao
>            Assignee: He Xiaoqiao
>            Priority: Major
>             Fix For: 2.10.0, 3.3.0
>
>         Attachments: HDFS-14632.001.patch, HDFS-14632.002.patch, 
> HDFS-14632.003.patch, HDFS-14632.004.patch, HDFS-14632.005.patch, 
> HDFS-14632.006.patch
>
>
> As mentioned HDFS-14171, SafeModeMonitor invoke useless #getNumLiveDataNodes 
> if not config DataNode threshold.
> The root cause is BlockManagerSafeMode#reportStatus(for trunk branch) or 
> SafeModeInfo#reportStatus (for branch-2.8) print status every 20 seconds and 
> invoke SafeModeInfo#getTurnOffTip.
> Optimize with checking if config DataNode threshold then decide to if get 
> number of live DataNodes.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to