[
https://issues.apache.org/jira/browse/HDDS-1856?focusedWorklogId=285265&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-285265
]
ASF GitHub Bot logged work on HDDS-1856:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Jul/19 21:22
Start Date: 30/Jul/19 21:22
Worklog Time Spent: 10m
Work Description: arp7 commented on pull request #1174: HDDS-1856. Make
required changes for Non-HA to use new HA code in OM.
URL: https://github.com/apache/hadoop/pull/1174#discussion_r308948890
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerDoubleBuffer.java
##########
@@ -61,6 +63,10 @@
private Queue<DoubleBufferEntry<OMClientResponse>> currentBuffer;
private Queue<DoubleBufferEntry<OMClientResponse>> readyBuffer;
+
+ private Queue<CompletableFuture<Void>> currentFutureQueue;
Review comment:
Can you add a one-line comment for the new fields?
Also we should probably add for the existing fields. I think some ASCII art
description of how double buffer works will be helpful to future maintainers.
However it's okay to file a follow up jira and do separately later. Don't need
to do it for this commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 285265)
Time Spent: 2.5h (was: 2h 20m)
> Make changes required for Non-HA to use new HA code in OM.
> ----------------------------------------------------------
>
> Key: HDDS-1856
> URL: https://issues.apache.org/jira/browse/HDDS-1856
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> In this Jira following things will be implemented:
> # Make the necessary changes for non-HA code path to use Cache and
> DoubleBuffer.
> ## When adding to double buffer, return future. This future will be used in
> the non-HA path to wait for this, and when it is completed return response to
> the client.
> ## Add to double-buffer will happen inside validateAndUpdateCache. In this
> way, in non-HA, when multiple RPC handler threads are calling preExecute and
> validateAndUpdateCache, the order inserted in to double buffer will happen in
> the order requests are received.
>
> In this Jira, we shall not convert non-ha code path to use this, as security
> and acl work is not completed to use this new model.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
