[
https://issues.apache.org/jira/browse/HDFS-14645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896534#comment-16896534
]
Wei-Chiu Chuang commented on HDFS-14645:
----------------------------------------
TestViewFileSystemClose test should have a time out.
{code}
// Just logging exception and close next FS.
LOG.info("Cannot close child file system", ie);
{code}
I think we should log a WARN. Other than this nit, the patch looks good.
> ViewFileSystem should close the child FileSystems in close()
> ------------------------------------------------------------
>
> Key: HDFS-14645
> URL: https://issues.apache.org/jira/browse/HDFS-14645
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs
> Affects Versions: 2.7.8, 3.3.0
> Reporter: Jihyun Cho
> Assignee: Jihyun Cho
> Priority: Major
> Attachments: HDFS-14645.001.patch, HDFS-14645.002.patch
>
>
> {{ViewFileSystem}} uses superclass's {{close}} in current implementation.
> It removes from {{FileSystem.CACHE}} without closing the child FileSystems.
> To close properly, when FileSystem is closing, its child FileSystems also
> should be closed.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
