[
https://issues.apache.org/jira/browse/HDFS-2450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137124#comment-13137124
]
Daryn Sharp commented on HDFS-2450:
-----------------------------------
Thanks for the review comments, Suresh!
# I see your point. I had originally thought about adding them there, but
reconsidered for the following reasons. If you have a strong preference, I
will try to move the tests to {{TestFileSystem}}.
#* I would have to copy-n-paste the test resolver into {{TestFileSystem}}
#* I couldn't use the test resolver from {{TestFileSystem}} w/o increasing the
visibility of {{NetUtils}} methods to control the resolver -- which I don't
think either of us would like to be publicly visible.
#* While the {{FileSystem}} related tests are exercising the ability of
{{checkPath(...)}} to compare canonicals, it also exercising the canonicalizing
code in {{NetUtils}}. I admit it's a tenuous connection.
# I contemplated whether {{getCanonicalUri()}} should be public. My final
decision was influenced by testability, but the main reason is I realized that
external callers cannot directly use {{NetUtils.getCanonicalUri(...)}} since
{{FileSystem#getDefaultPort()}} is a protected method. It seems natural to
publicly expose {{getUri()}} and {{getCanonicalUri()}}, but if you disagree, I
will try to change it.
> Only complete hostname is supported to access data via hdfs://
> --------------------------------------------------------------
>
> Key: HDFS-2450
> URL: https://issues.apache.org/jira/browse/HDFS-2450
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.20.205.0
> Reporter: Rajit Saha
> Assignee: Daryn Sharp
> Attachments: HDFS-2450-1.patch, HDFS-2450-2.patch, HDFS-2450-3.patch,
> HDFS-2450.patch, IP vs. Hostname.pdf
>
>
> If my complete hostname is host1.abc.xyz.com, only complete hostname must be
> used to access data via hdfs://
> I am running following in .20.205 Client to get data from .20.205 NN (host1)
> $hadoop dfs -copyFromLocal /etc/passwd hdfs://host1/tmp
> copyFromLocal: Wrong FS: hdfs://host1/tmp, expected: hdfs://host1.abc.xyz.com
> Usage: java FsShell [-copyFromLocal <localsrc> ... <dst>]
> $hadoop dfs -copyFromLocal /etc/passwd hdfs://host1.abc/tmp/
> copyFromLocal: Wrong FS: hdfs://host1.blue/tmp/1, expected:
> hdfs://host1.abc.xyz.com
> Usage: java FsShell [-copyFromLocal <localsrc> ... <dst>]
> $hadoop dfs -copyFromLocal /etc/passwd hftp://host1.abc.xyz/tmp/
> copyFromLocal: Wrong FS: hdfs://host1.blue/tmp/1, expected:
> hdfs://host1.abc.xyz.com
> Usage: java FsShell [-copyFromLocal <localsrc> ... <dst>]
> Only following is supported
> $hadoop dfs -copyFromLocal /etc/passwd hdfs://host1.abc.xyz.com/tmp/
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
