[
https://issues.apache.org/jira/browse/HDDS-1893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16900259#comment-16900259
]
Hudson commented on HDDS-1893:
------------------------------
FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #17041 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/17041/])
HDDS-1893. Fix bug in removeAcl in Bucket. (#1216) (xyao: rev
c589983e9cebe72f6db4f0141b9bb1b77c052838)
* (edit)
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/BucketManagerImpl.java
* (edit)
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestOzoneRpcClientAbstract.java
> Fix bug in removeAcl in Bucket
> ------------------------------
>
> Key: HDDS-1893
> URL: https://issues.apache.org/jira/browse/HDDS-1893
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: Ozone Manager, Security
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Blocker
> Labels: pull-request-available
> Fix For: 0.4.1
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> {code:java}
> // When we are removing subset of rights from existing acl.
> for(OzoneAcl a: bucketInfo.getAcls()) {
> if(a.getName().equals(acl.getName()) &&
> a.getType().equals(acl.getType())) {
> BitSet bits = (BitSet) acl.getAclBitSet().clone();
> bits.and(a.getAclBitSet());
> if (bits.equals(ZERO_BITSET)) {
> return false;
> }
> bits = (BitSet) acl.getAclBitSet().clone();
> bits.and(a.getAclBitSet());
> a.getAclBitSet().xor(bits);
> if(a.getAclBitSet().equals(ZERO_BITSET)) {
> bucketInfo.getAcls().remove(a);
> }
> break;
> } else {
> return false;
> }{code}
> In for loop, if first one is not matching with name and type, in else we
> return false. We should iterate entire acl list and then return response.
> }
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
