[ 
https://issues.apache.org/jira/browse/HDDS-1917?focusedWorklogId=290025&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-290025
 ]

ASF GitHub Bot logged work on HDDS-1917:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 06/Aug/19 21:57
            Start Date: 06/Aug/19 21:57
    Worklog Time Spent: 10m 
      Work Description: xiaoyuyao commented on pull request #1234: HDDS-1917. 
Ignore failing test-cases in TestSecureOzoneRpcClient.
URL: https://github.com/apache/hadoop/pull/1234#discussion_r311293111
 
 

 ##########
 File path: 
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestOzoneRpcClientAbstract.java
 ##########
 @@ -2280,6 +2280,7 @@ public void testNativeAclsForVolume() throws Exception {
     validateOzoneAccessAcl(ozObj);
   }
 
+  @Ignore("This will be fixed when HA support is added to acl operations")
 
 Review comment:
   Instead of Ignore for all subclasses, Can we just ignore these ACL related 
test cases for Ratis/HA like below at the begin of 
TestOzoneRpcClientAbstract#testNativeAclsForKey/Volume/Bucket/Prefix? This way, 
we still have all the coverage of non-HA cases for ACL, which is the main 
feature of ozone-0.4.1.
   
   {code}
       assumeFalse("Remove this once ACL HA is supported",
           getClass().equals(TestOzoneRpcClientWithRatis.class));
   {code}
   
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 290025)
    Time Spent: 40m  (was: 0.5h)

> Ignore failing test-cases in TestSecureOzoneRpcClient
> -----------------------------------------------------
>
>                 Key: HDDS-1917
>                 URL: https://issues.apache.org/jira/browse/HDDS-1917
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>            Reporter: Nanda kumar
>            Assignee: Nanda kumar
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> Ignore failing test-cases in TestSecureOzoneRpcClient. This will be fixed 
> when HA support is added to acl operations.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to