[
https://issues.apache.org/jira/browse/HDDS-1921?focusedWorklogId=290045&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-290045
]
ASF GitHub Bot logged work on HDDS-1921:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Aug/19 22:56
Start Date: 06/Aug/19 22:56
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #1238:
HDDS-1921. TestOzoneManagerDoubleBufferWithOMResponse is flaky
URL: https://github.com/apache/hadoop/pull/1238#discussion_r311309048
##########
File path:
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/ratis/TestOzoneManagerDoubleBufferWithOMResponse.java
##########
@@ -345,21 +345,23 @@ public void testDoubleBuffer(int iterations, int
bucketCount)
}
// We are doing +1 for volume transaction.
- GenericTestUtils.waitFor(() ->
- doubleBuffer.getFlushedTransactionCount() ==
- (bucketCount + 1) * iterations, 100,
- 120000);
+ long expectedTransactions = (bucketCount + 1) * iterations;
+ GenericTestUtils.waitFor(() -> lastAppliedIndex == expectedTransactions,
+ 100, 120000);
- Assert.assertTrue(omMetadataManager.countRowsInTable(
- omMetadataManager.getVolumeTable()) == iterations);
+ Assert.assertEquals(expectedTransactions,
+ doubleBuffer.getFlushedTransactionCount()
+ );
- Assert.assertTrue(omMetadataManager.countRowsInTable(
- omMetadataManager.getBucketTable()) == (bucketCount) * iterations);
+ Assert.assertEquals(iterations,
+
omMetadataManager.countRowsInTable(omMetadataManager.getVolumeTable())
+ );
- Assert.assertTrue(doubleBuffer.getFlushIterations() > 0);
+ Assert.assertEquals(bucketCount * iterations,
+
omMetadataManager.countRowsInTable(omMetadataManager.getBucketTable())
+ );
- // Check lastAppliedIndex is updated correctly or not.
- Assert.assertEquals((bucketCount + 1) * iterations, lastAppliedIndex);
Review comment:
Why this check lastAppliedIndex is removed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 290045)
Time Spent: 40m (was: 0.5h)
> TestOzoneManagerDoubleBufferWithOMResponse is flaky
> ---------------------------------------------------
>
> Key: HDDS-1921
> URL: https://issues.apache.org/jira/browse/HDDS-1921
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: test
> Affects Versions: 0.4.1
> Reporter: Doroszlai, Attila
> Assignee: Doroszlai, Attila
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> {noformat:title=https://ci.anzix.net/job/ozone/17588/testReport/org.apache.hadoop.ozone.om.ratis/TestOzoneManagerDoubleBufferWithOMResponse/testDoubleBuffer/}
> java.lang.AssertionError: expected:<11> but was:<9>
> ...
> at
> org.apache.hadoop.ozone.om.ratis.TestOzoneManagerDoubleBufferWithOMResponse.testDoubleBuffer(TestOzoneManagerDoubleBufferWithOMResponse.java:362)
> at
> org.apache.hadoop.ozone.om.ratis.TestOzoneManagerDoubleBufferWithOMResponse.testDoubleBuffer(TestOzoneManagerDoubleBufferWithOMResponse.java:104)
> {noformat}
> {noformat:title=https://ci.anzix.net/job/ozone/17587/testReport/org.apache.hadoop.ozone.om.ratis/TestOzoneManagerDoubleBufferWithOMResponse/unit___testDoubleBuffer/}
> java.lang.AssertionError: expected:<11> but was:<3>
> ...
> at
> org.apache.hadoop.ozone.om.ratis.TestOzoneManagerDoubleBufferWithOMResponse.testDoubleBuffer(TestOzoneManagerDoubleBufferWithOMResponse.java:362)
> at
> org.apache.hadoop.ozone.om.ratis.TestOzoneManagerDoubleBufferWithOMResponse.testDoubleBuffer(TestOzoneManagerDoubleBufferWithOMResponse.java:104)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
