[
https://issues.apache.org/jira/browse/HDFS-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13138201#comment-13138201
]
Uma Maheswara Rao G commented on HDFS-2493:
-------------------------------------------
Hi Nicholas,
I just review the patch!
Patch looks good.
small nits:
1) ReplicationMonitor#computeDatanodeWork:
Can we update the below comment, it still says FSNameSystemMetrics in
BlockManager. But counters we alrady moved to BlockManager.
// Update FSNamesystemMetrics counters
2) There are many static imports explicitely for each Constant. Is it
intensional?
Looks file is filled with many imports. Can't it be used with *?
+1 after addressing above.
> Remove reference to FSNamesystem in blockmanagement classes
> -----------------------------------------------------------
>
> Key: HDFS-2493
> URL: https://issues.apache.org/jira/browse/HDFS-2493
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: name-node
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h2493_20111022.patch, h2493_20111022b.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
