[
https://issues.apache.org/jira/browse/HDDS-1895?focusedWorklogId=292249&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-292249
]
ASF GitHub Bot logged work on HDDS-1895:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Aug/19 21:11
Start Date: 09/Aug/19 21:11
Worklog Time Spent: 10m
Work Description: arp7 commented on pull request #1230: HDDS-1895.
Support Key ACL operations for OM HA.
URL: https://github.com/apache/hadoop/pull/1230#discussion_r312649376
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/utils/OzoneManagerRatisUtils.java
##########
@@ -141,20 +144,26 @@ private static OMClientRequest getOMAclRequest(OMRequest
omRequest) {
return new OMVolumeAddAclRequest(omRequest);
} else if (ObjectType.BUCKET == type) {
return new OMBucketAddAclRequest(omRequest);
+ } else if (type == ObjectType.KEY) {
Review comment:
The code is using reverse order for equality. Can you use the same?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 292249)
Time Spent: 1h 20m (was: 1h 10m)
> Support Key ACL operations for OM HA.
> -------------------------------------
>
> Key: HDDS-1895
> URL: https://issues.apache.org/jira/browse/HDDS-1895
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> +HDDS-1541+ adds 4 new api for Ozone rpc client. OM HA implementation needs
> to handle them.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
