[
https://issues.apache.org/jira/browse/HDDS-1927?focusedWorklogId=292727&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-292727
]
ASF GitHub Bot logged work on HDDS-1927:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Aug/19 17:18
Start Date: 11/Aug/19 17:18
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on issue #1263: HDDS-1927.
Consolidate add/remove Acl into OzoneAclUtil class. Contri…
URL: https://github.com/apache/hadoop/pull/1263#issuecomment-520245179
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| 0 | reexec | 41 | Docker mode activated. |
||| _ Prechecks _ |
| +1 | dupname | 1 | No case conflicting files found. |
| +1 | @author | 0 | The patch does not contain any @author tags. |
| +1 | test4tests | 0 | The patch appears to include 5 new or modified test
files. |
||| _ trunk Compile Tests _ |
| 0 | mvndep | 14 | Maven dependency ordering for branch |
| +1 | mvninstall | 566 | trunk passed |
| +1 | compile | 344 | trunk passed |
| +1 | checkstyle | 72 | trunk passed |
| +1 | mvnsite | 0 | trunk passed |
| +1 | shadedclient | 808 | branch has no errors when building and testing
our client artifacts. |
| +1 | javadoc | 149 | trunk passed |
| 0 | spotbugs | 439 | Used deprecated FindBugs config; considering
switching to SpotBugs. |
| +1 | findbugs | 636 | trunk passed |
||| _ Patch Compile Tests _ |
| 0 | mvndep | 21 | Maven dependency ordering for patch |
| +1 | mvninstall | 537 | the patch passed |
| +1 | compile | 354 | the patch passed |
| +1 | javac | 354 | the patch passed |
| +1 | checkstyle | 72 | the patch passed |
| +1 | mvnsite | 0 | the patch passed |
| +1 | whitespace | 0 | The patch has no whitespace issues. |
| +1 | shadedclient | 616 | patch has no errors when building and testing
our client artifacts. |
| +1 | javadoc | 153 | the patch passed |
| +1 | findbugs | 643 | the patch passed |
||| _ Other Tests _ |
| +1 | unit | 285 | hadoop-hdds in the patch passed. |
| -1 | unit | 2520 | hadoop-ozone in the patch failed. |
| +1 | asflicense | 46 | The patch does not generate ASF License warnings. |
| | | 8029 | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests |
hadoop.ozone.container.common.statemachine.commandhandler.TestBlockDeletion |
| | hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures |
| | hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient |
| | hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory |
| | hadoop.ozone.client.rpc.TestCommitWatcher |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.1 Server=19.03.1 base:
https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/10/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/1263 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux d45fbfaf9971 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / cf5d895 |
| Default Java | 1.8.0_212 |
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/10/artifact/out/patch-unit-hadoop-ozone.txt
|
| Test Results |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/10/testReport/ |
| Max. process+thread count | 4431 (vs. ulimit of 5500) |
| modules | C: hadoop-ozone/common hadoop-ozone/client
hadoop-ozone/ozone-manager hadoop-ozone/objectstore-service
hadoop-ozone/integration-test U: hadoop-ozone |
| Console output |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/10/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
| Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 292727)
Time Spent: 2h (was: 1h 50m)
> Consolidate add/remove Acl into OzoneAclUtil class
> --------------------------------------------------
>
> Key: HDDS-1927
> URL: https://issues.apache.org/jira/browse/HDDS-1927
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Bharat Viswanadham
> Assignee: Xiaoyu Yao
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h
> Remaining Estimate: 0h
>
> This Jira is created based on @xiaoyu comment on HDDS-1884
> Can we abstract these add/remove logic into common AclUtil class as we can
> see similar logic in both bucket manager and key manager? For example,
> public static boolean addAcl(List existingAcls, OzoneAcl newAcl)
> public static boolean removeAcl(List existingAcls, OzoneAcl newAcl)
>
> But to do this, we need both OmKeyInfo and OMBucketInfo to use list of
> OzoneAcl/OzoneAclInfo.
> This Jira is to do that refactor, and also address above comment to move
> common logic to AclUtils.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
