[
https://issues.apache.org/jira/browse/HDDS-1956?focusedWorklogId=293971&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-293971
]
ASF GitHub Bot logged work on HDDS-1956:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Aug/19 15:40
Start Date: 13/Aug/19 15:40
Worklog Time Spent: 10m
Work Description: adoroszlai commented on pull request #1287: HDDS-1956.
Aged IO Thread exits on first read
URL: https://github.com/apache/hadoop/pull/1287#discussion_r313470272
##########
File path:
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/MiniOzoneLoadGenerator.java
##########
@@ -201,11 +210,12 @@ private void startAgedFilesLoad(long runTimeMillis) {
String keyName = null;
try {
if (agedWriteProbability.isTrue()) {
- keyName = writeData(agedFileWrittenIndex.incrementAndGet(),
+ keyName = writeData(agedFileWrittenIndex.getAndIncrement(),
Review comment:
Can you please clarify what's the issue here?
Random index selection gives a number in `[0, currentIndex)` (see
`RandomUtils.nextInt(0, currentIndex)`).
Previously files were written starting at 1 and `currentIndex` equaled the
last written key index. Now `currentIndex` is last written key index + 1, so
the random choice always produces an existing key index.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 293971)
Time Spent: 1h 10m (was: 1h)
> Aged IO Thread exits on first read
> ----------------------------------
>
> Key: HDDS-1956
> URL: https://issues.apache.org/jira/browse/HDDS-1956
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: test
> Affects Versions: 0.5.0
> Reporter: Doroszlai, Attila
> Assignee: Doroszlai, Attila
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Aged IO Thread in {{TestMiniChaosOzoneCluster}} exits on first read due to
> exception:
> {code}
> 2019-08-12 22:55:37,799 [pool-245-thread-1] INFO
> ozone.MiniOzoneLoadGenerator
> (MiniOzoneLoadGenerator.java:startAgedFilesLoad(194)) - AGED LOADGEN: Started
> Aged IO Thread:2139.
> ...
> 2019-08-12 22:55:47,147 [pool-245-thread-1] ERROR
> ozone.MiniOzoneLoadGenerator
> (MiniOzoneLoadGenerator.java:startAgedFilesLoad(213)) - AGED LOADGEN: 0
> Exiting due to exception
> java.lang.ArrayIndexOutOfBoundsException: 1
> at
> org.apache.hadoop.ozone.MiniOzoneLoadGenerator.readData(MiniOzoneLoadGenerator.java:151)
> at
> org.apache.hadoop.ozone.MiniOzoneLoadGenerator.startAgedFilesLoad(MiniOzoneLoadGenerator.java:209)
> at
> org.apache.hadoop.ozone.MiniOzoneLoadGenerator.lambda$startIO$1(MiniOzoneLoadGenerator.java:235)
> 2019-08-12 22:55:47,149 [pool-245-thread-1] INFO
> ozone.MiniOzoneLoadGenerator
> (MiniOzoneLoadGenerator.java:startAgedFilesLoad(219)) - Terminating IO
> thread:2139.
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
