[
https://issues.apache.org/jira/browse/HDDS-1886?focusedWorklogId=294214&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-294214
]
ASF GitHub Bot logged work on HDDS-1886:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Aug/19 21:46
Start Date: 13/Aug/19 21:46
Worklog Time Spent: 10m
Work Description: anuengineer commented on pull request #1205: HDDS-1886.
Use ArrayList#clear to address audit failure scenario
URL: https://github.com/apache/hadoop/pull/1205#discussion_r313627412
##########
File path:
hadoop-hdds/common/src/test/java/org/apache/hadoop/ozone/audit/TestOzoneAuditLogger.java
##########
@@ -153,7 +153,7 @@ private void verifyLog(String expected) throws IOException
{
assertTrue(lines.size() != 0);
assertTrue(expected.equalsIgnoreCase(lines.get(0)));
//empty the file
- lines.remove(0);
+ lines.clear();
Review comment:
@adoroszlai Thanks for the review. I will commit this now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 294214)
Time Spent: 2h (was: 1h 50m)
> Use ArrayList#clear to address audit failure scenario
> -----------------------------------------------------
>
> Key: HDDS-1886
> URL: https://issues.apache.org/jira/browse/HDDS-1886
> Project: Hadoop Distributed Data Store
> Issue Type: Test
> Components: test
> Reporter: Dinesh Chitlangia
> Assignee: Dinesh Chitlangia
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 2h
> Remaining Estimate: 0h
>
> TestOzoneAuditLogger makes use of ArrayList#remove to clear the log file in
> between test runs.
> When writing tests in future for more failures scenarios, the tests will fail
> if the log entry has multi-line stack trace in audit logs.
> This jira aims to use ArrayList#clear to make the test future proof.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
