[ 
https://issues.apache.org/jira/browse/HDFS-14719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907063#comment-16907063
 ] 

Surendra Singh Lilhore commented on HDFS-14719:
-----------------------------------------------

LGTM, +1

> Correct the safemode threshold value in BlockManagerSafeMode
> ------------------------------------------------------------
>
>                 Key: HDFS-14719
>                 URL: https://issues.apache.org/jira/browse/HDFS-14719
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 3.1.1
>            Reporter: Surendra Singh Lilhore
>            Assignee: hemanthboyina
>            Priority: Major
>         Attachments: HDFS-14719.002.patch, HDFS-14719.patch
>
>
> BlockManagerSafeMode is doing wrong parsing forĀ safemode threshold. It is 
> storing float value in double, which will give different result some time. If 
> we storeĀ "0.999f" value in double then it will be converted to 
> "0.9990000128746033".
> {code:java}
> this.threshold = conf.getFloat(DFS_NAMENODE_SAFEMODE_THRESHOLD_PCT_KEY,
> DFS_NAMENODE_SAFEMODE_THRESHOLD_PCT_DEFAULT);{code}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to