[ 
https://issues.apache.org/jira/browse/HDFS-2470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16908817#comment-16908817
 ] 

Siddharth Wagle commented on HDFS-2470:
---------------------------------------

- Agree with point #1, will ignore root directory permissions, [~arp] you ok 
with that since you +1ed earlier.
- Regarding point #2, I did not want the generic StorageDirectory class to 
define a default, hence defined the default for NN and JN separately, and since 
unit tests don't care about setting permissions, went with a null check to skip 
permission setting instead. But, do you mean we should change all unit-test 
call sites to pass a default 700 permission? That would be ok I guess.

> NN should automatically set permissions on dfs.namenode.*.dir
> -------------------------------------------------------------
>
>                 Key: HDFS-2470
>                 URL: https://issues.apache.org/jira/browse/HDFS-2470
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 2.0.0-alpha
>            Reporter: Aaron T. Myers
>            Assignee: Siddharth Wagle
>            Priority: Major
>         Attachments: HDFS-2470.01.patch, HDFS-2470.02.patch, 
> HDFS-2470.03.patch, HDFS-2470.04.patch, HDFS-2470.05.patch, 
> HDFS-2470.06.patch, HDFS-2470.07.patch
>
>
> Much as the DN currently sets the correct permissions for the 
> dfs.datanode.data.dir, the NN should do the same for the 
> dfs.namenode.(name|edit).dir.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to