[ 
https://issues.apache.org/jira/browse/HDFS-14456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16909518#comment-16909518
 ] 

Hudson commented on HDFS-14456:
-------------------------------

FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #17138 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/17138/])
HDFS-14456:HAState#prepareToEnterState neednt a lock (#770) Contributed 
(weichiu: rev a38b9e137e67571d2df83a7a9505b66cffefa7c8)
* (edit) 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java


> HAState#prepareToEnterState needn't a lock
> ------------------------------------------
>
>                 Key: HDFS-14456
>                 URL: https://issues.apache.org/jira/browse/HDFS-14456
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs
>    Affects Versions: 3.2.0
>            Reporter: hunshenshi
>            Assignee: hunshenshi
>            Priority: Major
>             Fix For: 3.3.0
>
>
> prepareToEnterState in HAState is called without the context being locked.
> But in NameNode#NameNode, prepareToEnterState is after haContext.writeLock()
>  
> {code:java}
> try {
>   haContext.writeLock();
>   state.prepareToEnterState(haContext);
>   state.enterState(haContext);
> } finally {
>   haContext.writeUnlock();
> }
> {code}
>  
> Is it OK?
>  



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to