[
https://issues.apache.org/jira/browse/HDFS-14714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16911503#comment-16911503
]
Íñigo Goiri commented on HDFS-14714:
------------------------------------
A couple minor comments:
* In the assertEquals in line 1412, we should have the expected value first.
* When we extract FSNamesystem, we could extract BlockManager from it.
* I would do all the extracts in the top of the for loop.
* Add a general comment to testGetRelicatedBlockStats explaining how you
generate a corrupted block.
> RBF: implement getReplicatedBlockStats interface
> ------------------------------------------------
>
> Key: HDFS-14714
> URL: https://issues.apache.org/jira/browse/HDFS-14714
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Chen Zhang
> Assignee: Chen Zhang
> Priority: Major
> Attachments: HDFS-14714.001.patch, HDFS-14714.002.patch,
> HDFS-14714.003.patch
>
>
> It's not implemented now, we sometime need this interface for cluster monitor
> {code:java}
> // current implementation
> public ReplicatedBlockStats getReplicatedBlockStats() throws IOException {
> rpcServer.checkOperation(NameNode.OperationCategory.READ, false);
> return null;
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
