[
https://issues.apache.org/jira/browse/HDDS-1927?focusedWorklogId=298189&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-298189
]
ASF GitHub Bot logged work on HDDS-1927:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Aug/19 21:02
Start Date: 20/Aug/19 21:02
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #1263:
HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri…
URL: https://github.com/apache/hadoop/pull/1263#discussion_r315901670
##########
File path:
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmKeyInfo.java
##########
@@ -235,123 +231,22 @@ public FileEncryptionInfo getFileEncryptionInfo() {
return encInfo;
}
- public List<OzoneAclInfo> getAcls() {
+ public List<OzoneAcl> getAcls() {
Review comment:
> Good point. CheckAccess does the the byte array based protobuf acl to
BitSet based acl conversion each time, which is most of the work we do for
protobuf conversion from OzoneAclInfo to OzoneAcl. Consolidate this into
OzoneAcl class allows us to change the logic in a single place for optimization
in future.
Ya right. I think it should be fine I believe. (But still, we have little
advantage of not converting entire protobuf object. But I am fine with the
current way. :))
> Key creation usually needs to inherit the acls from prefix tree, where
efficient merge of supplied acls along with the acls from in-memory prefix
tree. It is currently not done properly tracked by HDDS-1913.
HDDS-1913 is for fixing OzoneBucket and RpcClient APIS for acl. Is there
another jira to fix the above issue?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 298189)
Time Spent: 5.5h (was: 5h 20m)
> Consolidate add/remove Acl into OzoneAclUtil class
> --------------------------------------------------
>
> Key: HDDS-1927
> URL: https://issues.apache.org/jira/browse/HDDS-1927
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Bharat Viswanadham
> Assignee: Xiaoyu Yao
> Priority: Major
> Labels: pull-request-available
> Time Spent: 5.5h
> Remaining Estimate: 0h
>
> This Jira is created based on @xiaoyu comment on HDDS-1884
> Can we abstract these add/remove logic into common AclUtil class as we can
> see similar logic in both bucket manager and key manager? For example,
> public static boolean addAcl(List existingAcls, OzoneAcl newAcl)
> public static boolean removeAcl(List existingAcls, OzoneAcl newAcl)
>
> But to do this, we need both OmKeyInfo and OMBucketInfo to use list of
> OzoneAcl/OzoneAclInfo.
> This Jira is to do that refactor, and also address above comment to move
> common logic to AclUtils.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
