[
https://issues.apache.org/jira/browse/HDFS-14760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
CR Hota updated HDFS-14760:
---------------------------
Description:
In DirectoryWithQuotaFeature#checkStoragespace code logs in error mode without
throwing any exceptions or action and pollutes logs. This should be in INFO
mode.
{code}
private void checkStoragespace(final INodeDirectory dir, final long computed)
{
if (-1 != quota.getStorageSpace() && usage.getStorageSpace() != computed) {
NameNode.LOG.error("BUG: Inconsistent storagespace for directory "
+ dir.getFullPathName() + ". Cached = " + usage.getStorageSpace()
+ " != Computed = " + computed);
}
}
{code}
was:
{code}
private void checkStoragespace(final INodeDirectory dir, final long computed)
{
if (-1 != quota.getStorageSpace() && usage.getStorageSpace() != computed) {
NameNode.LOG.error("BUG: Inconsistent storagespace for directory "
+ dir.getFullPathName() + ". Cached = " + usage.getStorageSpace()
+ " != Computed = " + computed);
}
}
{code}
The above code logs in error mode without throwing any exceptions or action and
pollutes logs. This should be in INFO mode.
> Log INFO mode if snapshot usage and actual usage differ
> -------------------------------------------------------
>
> Key: HDFS-14760
> URL: https://issues.apache.org/jira/browse/HDFS-14760
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: CR Hota
> Assignee: CR Hota
> Priority: Major
>
> In DirectoryWithQuotaFeature#checkStoragespace code logs in error mode
> without throwing any exceptions or action and pollutes logs. This should be
> in INFO mode.
> {code}
> private void checkStoragespace(final INodeDirectory dir, final long
> computed) {
> if (-1 != quota.getStorageSpace() && usage.getStorageSpace() != computed)
> {
> NameNode.LOG.error("BUG: Inconsistent storagespace for directory "
> + dir.getFullPathName() + ". Cached = " + usage.getStorageSpace()
> + " != Computed = " + computed);
> }
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
