[
https://issues.apache.org/jira/browse/HDDS-1973?focusedWorklogId=298397&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-298397
]
ASF GitHub Bot logged work on HDDS-1973:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Aug/19 03:14
Start Date: 21/Aug/19 03:14
Worklog Time Spent: 10m
Work Description: arp7 commented on pull request #1316: HDDS-1973.
Implement OM RenewDelegationToken request to use Cache and DoubleBuffer.
URL: https://github.com/apache/hadoop/pull/1316#discussion_r315983569
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/security/OMRenewDelegationTokenRequest.java
##########
@@ -0,0 +1,164 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.ozone.om.request.security;
+
+import java.io.IOException;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import com.google.common.base.Optional;
+import org.apache.hadoop.ozone.om.OMMetadataManager;
+import org.apache.hadoop.ozone.om.OzoneManager;
+import org.apache.hadoop.ozone.om.ratis.utils.OzoneManagerDoubleBufferHelper;
+import org.apache.hadoop.ozone.om.request.OMClientRequest;
+import org.apache.hadoop.ozone.om.response.OMClientResponse;
+import
org.apache.hadoop.ozone.om.response.security.OMRenewDelegationTokenResponse;
+import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos;
+import
org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos.OMRequest;
+import
org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos.OMResponse;
+import
org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos.RenewDelegationTokenResponseProto;
+import
org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos.UpdateRenewDelegationTokenRequest;
+import org.apache.hadoop.ozone.protocolPB.OMPBHelper;
+import org.apache.hadoop.ozone.security.OzoneTokenIdentifier;
+import
org.apache.hadoop.security.proto.SecurityProtos.RenewDelegationTokenRequestProto;
+import org.apache.hadoop.security.token.Token;
+import org.apache.hadoop.utils.db.cache.CacheKey;
+import org.apache.hadoop.utils.db.cache.CacheValue;
+
+/**
+ * Handle RenewDelegationToken Request.
+ */
+public class OMRenewDelegationTokenRequest extends OMClientRequest {
+
+ private static final Logger LOG =
+ LoggerFactory.getLogger(OMGetDelegationTokenRequest.class);
+
+ public OMRenewDelegationTokenRequest(OMRequest omRequest) {
+ super(omRequest);
+ }
+
+ @Override
+ public OMRequest preExecute(OzoneManager ozoneManager) throws IOException {
+ RenewDelegationTokenRequestProto renewDelegationTokenRequest =
+ getOmRequest().getRenewDelegationTokenRequest();
+
+ // Call OM to renew token
+ long renewTime = ozoneManager.renewDelegationToken(
+ OMPBHelper.convertToDelegationToken(
+ renewDelegationTokenRequest.getToken()));
+
+ RenewDelegationTokenResponseProto.Builder renewResponse =
+ RenewDelegationTokenResponseProto.newBuilder();
+
+ renewResponse.setResponse(org.apache.hadoop.security.proto.SecurityProtos
+ .RenewDelegationTokenResponseProto.newBuilder()
+ .setNewExpiryTime(renewTime));
+
+
+ // Client issues RenewDelegationToken request, when received by OM leader
+ // it will renew the token. Original RenewDelegationToken request is
+ // converted to UpdateRenewDelegationToken request with the token and renew
+ // information. This updated request will be submitted to Ratis. In this
+ // way delegation token renewd by leader, will be replicated across all
+ // OMs. With this approach, original RenewDelegationToken request from
+ // client does not need any proto changes.
+
+ // Create UpdateRenewDelegationTokenRequest with original request and
+ // expiry time.
+ OMRequest.Builder omRequest = OMRequest.newBuilder()
+ .setUserInfo(getUserInfo())
+ .setUpdatedRenewDelegationTokenRequest(
+ UpdateRenewDelegationTokenRequest.newBuilder()
+ .setRenewDelegationTokenRequest(renewDelegationTokenRequest)
+ .setRenewDelegationTokenResponse(renewResponse))
+ .setCmdType(getOmRequest().getCmdType())
Review comment:
I agree this is a bit hard to follow. I also had a long discussion with
Bharat while reviewing the createDelegationToken patch. I am okay to live with
for now to avoid creating yet another request class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 298397)
Time Spent: 2h (was: 1h 50m)
> Implement OM RenewDelegationToken request to use Cache and DoubleBuffer
> -----------------------------------------------------------------------
>
> Key: HDDS-1973
> URL: https://issues.apache.org/jira/browse/HDDS-1973
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: Ozone Manager
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Implement OM RenewDelegationToken request to use OM Cache, double buffer.
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
