[ https://issues.apache.org/jira/browse/HDDS-1981?focusedWorklogId=298622&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-298622 ]
ASF GitHub Bot logged work on HDDS-1981: ---------------------------------------- Author: ASF GitHub Bot Created on: 21/Aug/19 11:55 Start Date: 21/Aug/19 11:55 Worklog Time Spent: 10m Work Description: supratimdeka commented on pull request #1319: HDDS-1981: Datanode should sync db when container is moved to CLOSED or QUASI_CLOSED state URL: https://github.com/apache/hadoop/pull/1319#discussion_r316143182 ########## File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueContainer.java ########## @@ -318,6 +326,8 @@ public void close() throws StorageContainerException { // It is ok if this operation takes a bit of time. // Close container is not expected to be instantaneous. compactDB(); Review comment: question unrelated to this patch : why do we need to run compact during close? what is the benefit? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 298622) Time Spent: 40m (was: 0.5h) > Datanode should sync db when container is moved to CLOSED or QUASI_CLOSED > state > ------------------------------------------------------------------------------- > > Key: HDDS-1981 > URL: https://issues.apache.org/jira/browse/HDDS-1981 > Project: Hadoop Distributed Data Store > Issue Type: Bug > Components: Ozone Datanode > Reporter: Lokesh Jain > Assignee: Lokesh Jain > Priority: Major > Labels: pull-request-available > Time Spent: 40m > Remaining Estimate: 0h > > Datanode should sync db when container is moved to CLOSED or QUASI_CLOSED > state. This will ensure that the metadata is persisted. -- This message was sent by Atlassian Jira (v8.3.2#803003) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org