[
https://issues.apache.org/jira/browse/HDDS-1347?focusedWorklogId=299022&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-299022
]
ASF GitHub Bot logged work on HDDS-1347:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Aug/19 21:06
Start Date: 21/Aug/19 21:06
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #670:
HDDS-1347. In OM HA getS3Secret call Should happen only leader OM.
URL: https://github.com/apache/hadoop/pull/670#discussion_r316390671
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
##########
@@ -2683,6 +2683,14 @@ public void deleteS3Bucket(String s3BucketName) throws
IOException {
* {@inheritDoc}
*/
public S3SecretValue getS3Secret(String kerberosID) throws IOException{
+ UserGroupInformation user = ProtobufRpcEngine.Server.getRemoteUser();
+
+ // Check whether user name passed is matching with the current user or not.
Review comment:
This was based on some related review comments when original change for
getS3Secret is implemented.
So, I implemented it as part of this.
As without this, some other user can get secrets for other users's.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 299022)
Time Spent: 2h (was: 1h 50m)
> Implement GetS3Secret to use double buffer and cache.
> -----------------------------------------------------
>
> Key: HDDS-1347
> URL: https://issues.apache.org/jira/browse/HDDS-1347
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.5.0
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> In Om HA getS3Secret should happen only leader OM.
>
>
> The reason is similar to initiateMultipartUpload. For more info refer
> HDDS-1319
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
