[
https://issues.apache.org/jira/browse/HDFS-2065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140563#comment-13140563
]
Tsz Wo (Nicholas), SZE commented on HDFS-2065:
----------------------------------------------
+1 Patch looks good. Thanks!
One nite: could you put {{locatedblocks = blockLocations.getLocatedBlocks();}}
in one line?
Although getLocatedBlocks() won't return null in trunk, could you also post a
similar patch for trunk? It is good to check null and your patch also adds a
test.
> Fix NPE in DFSClient.getFileChecksum
> ------------------------------------
>
> Key: HDFS-2065
> URL: https://issues.apache.org/jira/browse/HDFS-2065
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.23.0
> Reporter: Bharath Mundlapudi
> Assignee: Uma Maheswara Rao G
> Fix For: 0.24.0
>
> Attachments: HDFS-2065-1.patch, HDFS-2065-20.205Security.patch
>
>
> The following code can throw NPE if callGetBlockLocations returns null.
> If server returns null
> {code}
> List<LocatedBlock> locatedblocks
> = callGetBlockLocations(namenode, src, 0,
> Long.MAX_VALUE).getLocatedBlocks();
> {code}
> The right fix for this is server should throw right exception.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
