[
https://issues.apache.org/jira/browse/HDFS-2521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140718#comment-13140718
]
Hadoop QA commented on HDFS-2521:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12501691/hdfs-2521.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.cli.TestHDFSCLI
org.apache.hadoop.hdfs.TestFileCreationClient
org.apache.hadoop.hdfs.TestSetrepIncreasing
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/1508//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1508//console
This message is automatically generated.
> Remove custom checksum headers from data transfer protocol
> ----------------------------------------------------------
>
> Key: HDFS-2521
> URL: https://issues.apache.org/jira/browse/HDFS-2521
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node, hdfs client
> Affects Versions: 0.23.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: hdfs-2521-on-2512.txt, hdfs-2521.txt
>
>
> Most of the data transfer protocol has been converted over to protobufs, but
> we still send the checksum header with ad-hoc serialization in a few places.
> This is self-inconsistent and also makes wire protocol compatibility more
> difficult. This JIRA does the following:
> - introduce a new protobuf message to describe a checksum
> - include the "requested checksum" with the block operation (instead of
> coming separately after it)
> - include the "required checksum" with the block operation response, for
> write operations (instead of coming first in the BlockSender stream)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
