[
https://issues.apache.org/jira/browse/HDFS-14721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16913936#comment-16913936
]
xuzq commented on HDFS-14721:
-----------------------------
[~elgoiri] [~ayushtkn] Please review [^HDFS-14721-trunk-003.patch], thanks.
> RBF: ProxyOpComplete is not accurate in FederationRPCPerformanceMonitor
> -----------------------------------------------------------------------
>
> Key: HDFS-14721
> URL: https://issues.apache.org/jira/browse/HDFS-14721
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: rbf
> Reporter: xuzq
> Assignee: xuzq
> Priority: Major
> Attachments: HDFS-14721-trunk-001.patch, HDFS-14721-trunk-002.patch,
> HDFS-14721-trunk-003.patch
>
>
> ProxyOpComplete is not accurate in FederationRPCPerformanceMonitor when
> RemoteException is returned.
> Because the remoteException is unwrap in invoke method, and it will be
> proxyOpComplete(false) in invokeMethod.
> {code:java}
> // invoke method
> if (ioe instanceof RemoteException) {
> RemoteException re = (RemoteException) ioe;
> ioe = re.unwrapRemoteException();
> ioe = getCleanException(ioe);
> }
> // invokeMethod method
> if (this.rpcMonitor != null) {
> this.rpcMonitor.proxyOpFailureCommunicate();
> this.rpcMonitor.proxyOpComplete(false);
> }
> throw ioe;{code}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]