[ 
https://issues.apache.org/jira/browse/HDFS-8631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16914072#comment-16914072
 ] 

Surendra Singh Lilhore commented on HDFS-8631:
----------------------------------------------

Thanks [~csun]  for patch.

Some points from my side..

1. "0" should be considered as a valid value for space quota.

{code}
+ if (quota <= 0 && quota != HdfsConstants.QUOTA_RESET) {
+ throw new IllegalArgumentException("Invalid values for quota :" + quota);
+ }
{code}

2. Why {{FSOperations}} changes is required? Are you planning to implement this 
API in {{HttpFSServer}}.

> WebHDFS : Support setQuota
> --------------------------
>
>                 Key: HDFS-8631
>                 URL: https://issues.apache.org/jira/browse/HDFS-8631
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>    Affects Versions: 2.7.2
>            Reporter: nijel
>            Assignee: Chao Sun
>            Priority: Major
>         Attachments: HDFS-8631-001.patch, HDFS-8631-002.patch, 
> HDFS-8631-003.patch, HDFS-8631-004.patch, HDFS-8631-005.patch, 
> HDFS-8631-006.patch, HDFS-8631-007.patch, HDFS-8631-008.patch, 
> HDFS-8631-009.patch, HDFS-8631-010.patch
>
>
> User is able do quota management from filesystem object. Same operation can 
> be allowed trough REST API.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to