[
https://issues.apache.org/jira/browse/HDDS-2024?focusedWorklogId=300205&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-300205
]
ASF GitHub Bot logged work on HDDS-2024:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Aug/19 10:02
Start Date: 23/Aug/19 10:02
Worklog Time Spent: 10m
Work Description: adoroszlai commented on pull request #1343: HDDS-2024.
Fix rat.sh problems
URL: https://github.com/apache/hadoop/pull/1343
## What changes were proposed in this pull request?
Fix problems in `rat.sh`:
1. `grep: warning: recursive search of stdin` due to missing search target
(which works with GNU grep, but not with some others)
2. `cat: target/rat-aggregated.txt: No such file or directory` due mismatch
of `REPORT_FILE` value vs. literal
3. typo in `REPORT_FILE` value
Also: use `-s` test instead of `cat` (probably cheaper and safer).
https://issues.apache.org/jira/browse/HDDS-2024
## How was this patch tested?
```
$ ./hadoop-ozone/dev-support/checks/rat.sh
...
[INFO] Build failures were ignored.
hadoop-hdds/common/target/rat.txt: !?????
/Users/adoroszlai/src/hadoop/hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/cache/CacheResult.java
hadoop-ozone/dist/target/rat.txt: !?????
/Users/adoroszlai/src/hadoop/hadoop-ozone/dist/src/main/compose/ozones3-haproxy/haproxy-conf/haproxy.cfg
hadoop-ozone/integration-test/target/rat.txt: !?????
/Users/adoroszlai/src/hadoop/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestOzoneRpcClientForAclAuditLog.java
hadoop-ozone/common/target/rat.txt: !?????
/Users/adoroszlai/src/hadoop/hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/util/BooleanBiFunction.java
hadoop-ozone/ozone-manager/target/rat.txt: !?????
/Users/adoroszlai/src/hadoop/hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/response/s3/bucket/TestS3BucketDeleteResponse.java
hadoop-ozone/ozone-manager/target/rat.txt: !?????
/Users/adoroszlai/src/hadoop/hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/response/s3/multipart/TestS3MultipartUploadAbortResponse.java
hadoop-ozone/ozone-manager/target/rat.txt: !?????
/Users/adoroszlai/src/hadoop/hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/s3/multipart/TestS3MultipartUploadCompleteRequest.java
hadoop-ozone/ozone-manager/target/rat.txt: !?????
/Users/adoroszlai/src/hadoop/hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/s3/multipart/TestS3MultipartUploadAbortRequest.java
hadoop-ozone/ozone-manager/target/rat.txt: !?????
/Users/adoroszlai/src/hadoop/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/response/s3/multipart/S3MultipartUploadCompleteResponse.java
hadoop-ozone/ozone-manager/target/rat.txt: !?????
/Users/adoroszlai/src/hadoop/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/response/key/OMKeyPurgeResponse.java
hadoop-ozone/ozone-manager/target/rat.txt: !?????
/Users/adoroszlai/src/hadoop/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/utils/OzoneManagerDoubleBufferHelper.java
hadoop-ozone/ozone-manager/target/rat.txt: !?????
/Users/adoroszlai/src/hadoop/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/s3/multipart/S3MultipartUploadCompleteRequest.java
hadoop-ozone/ozone-manager/target/rat.txt: !?????
/Users/adoroszlai/src/hadoop/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyPurgeRequest.java
hadoop-ozone/ozone-manager/target/rat.txt: !?????
/Users/adoroszlai/src/hadoop/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/bucket/acl/OMBucketSetAclRequest.java
hadoop-ozone/ozone-manager/target/rat.txt: !?????
/Users/adoroszlai/src/hadoop/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/bucket/acl/OMBucketRemoveAclRequest.java
hadoop-ozone/ozone-manager/target/rat.txt: !?????
/Users/adoroszlai/src/hadoop/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/volume/acl/OMVolumeAclRequest.java
$ echo $?
1
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 300205)
Remaining Estimate: 0h
Time Spent: 10m
> rat.sh: grep: warning: recursive search of stdin
> ------------------------------------------------
>
> Key: HDDS-2024
> URL: https://issues.apache.org/jira/browse/HDDS-2024
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: build
> Affects Versions: 0.4.1
> Reporter: Doroszlai, Attila
> Assignee: Doroszlai, Attila
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Running {{rat.sh}} locally fails with the following error message (after the
> two Maven runs):
> {code:title=./hadoop-ozone/dev-support/checks/rat.sh}
> ...
> grep: warning: recursive search of stdin
> {code}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
