[
https://issues.apache.org/jira/browse/HDDS-1975?focusedWorklogId=300445&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-300445
]
ASF GitHub Bot logged work on HDDS-1975:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Aug/19 19:21
Start Date: 23/Aug/19 19:21
Worklog Time Spent: 10m
Work Description: xiaoyuyao commented on pull request #1315: HDDS-1975.
Implement default acls for bucket/volume/key for OM HA code.
URL: https://github.com/apache/hadoop/pull/1315#discussion_r317270565
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyRequest.java
##########
@@ -351,28 +362,65 @@ protected OmKeyInfo createKeyInfo(@Nonnull KeyArgs
keyArgs,
.setDataSize(size)
.setReplicationType(type)
.setReplicationFactor(factor)
- .setFileEncryptionInfo(encInfo);
+ .setFileEncryptionInfo(encInfo)
+ .setAcls(getAclsForKey(keyArgs, omBucketInfo, prefixManager)).build();
+ }
+
+ private List< OzoneAcl > getAclsForKey(KeyArgs keyArgs,
Review comment:
Can we move this to some common helper util such as OzoneAclUtil to avoid
duplicate code in KeyManagerImpl#getAclsForKey?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 300445)
Time Spent: 2h 20m (was: 2h 10m)
> Implement default acls for bucket/volume/key for OM HA code
> -----------------------------------------------------------
>
> Key: HDDS-1975
> URL: https://issues.apache.org/jira/browse/HDDS-1975
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.5.0
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> This Jira is to implement default ACLs for Ozone volume/bucket/key.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
