[
https://issues.apache.org/jira/browse/HDFS-14710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16915960#comment-16915960
]
Íñigo Goiri commented on HDFS-14710:
------------------------------------
This looks good.
Minor style comments in the test:
* Add a a space in between the variables setup and the creation (i.e., new line
in 258).
* Move 263 to the var setup.
* If you define some variables as final, for consistency you can do it to all.
* When creating the file from the Router (lines 261 and after) probably add the
comment right before the block.
* Line 295 checks the result of newBlock. For consistency with the other
checks, it should be in line 293.
* For consistency, not extra line in 301.
> RBF: Improve some RPC performances
> ----------------------------------
>
> Key: HDFS-14710
> URL: https://issues.apache.org/jira/browse/HDFS-14710
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: rbf
> Reporter: xuzq
> Assignee: xuzq
> Priority: Minor
> Attachments: HDFS-14710-trunk-001.patch, HDFS-14710-trunk-002.patch,
> HDFS-14710-trunk-003.patch, HDFS-14710-trunk-004.patch
>
>
> We can improve some RPC performance if the extendedBlock is not null.
> Such as addBlock, getAdditionalDatanode and complete.
> Since HDFS encourages user to write large files, so the extendedBlock is not
> null in most case.
> In the scenario of Multiple Destination and large file, the effect is more
> obvious.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
