[
https://issues.apache.org/jira/browse/HDDS-2030?focusedWorklogId=301769&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-301769
]
ASF GitHub Bot logged work on HDDS-2030:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Aug/19 08:01
Start Date: 27/Aug/19 08:01
Worklog Time Spent: 10m
Work Description: adoroszlai commented on pull request #1348: HDDS-2030.
Generate simplifed reports by the dev-support/checks/*.sh scripts
URL: https://github.com/apache/hadoop/pull/1348#discussion_r317943667
##########
File path: hadoop-ozone/dev-support/checks/acceptance.sh
##########
@@ -16,7 +16,20 @@
DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"
cd "$DIR/../../.." || exit 1
+REPORT_DIR=${OUTPUT_DIR:-"$DIR/../../../target/acceptance"}
+mkdir -p "$REPORT_DIR"
+
OZONE_VERSION=$(grep "<ozone.version>" "$DIR/../../pom.xml" | sed
's/<[^>]*>//g'| sed 's/^[ \t]*//')
-cd "$DIR/../../dist/target/ozone-$OZONE_VERSION/compose" || exit 1
+DIST_DIR="$DIR/../../dist/target/ozone-$OZONE_VERSION"
+
+if [ ! -d "$DIST_DIR" ]; then
+ echo "Distribution dir is missing. Doing a full build"
+ "$DIR/build.sh"
+fi
+
+cd "$DIST_DIR/compose" || exit 1
./test-all.sh
-exit $?
+RES=$?
+cp results/* "$REPORT_DIR/"
+cp "$REPORT_DIR/log.html" "$REPORT_DIR/summary.html"
+return $RES
Review comment:
bash says: `can only 'return' from a function or sourced script` (exit code
of `acceptance.sh` would be 1 if executed directly instead of sourcing it)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 301769)
Time Spent: 2h 20m (was: 2h 10m)
> Generate simplifed reports by the dev-support/checks/*.sh scripts
> -----------------------------------------------------------------
>
> Key: HDDS-2030
> URL: https://issues.apache.org/jira/browse/HDDS-2030
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: build
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> hadoop-ozone/dev-support/checks directory contains shell scripts to execute
> different type of code checks (findbugs, checkstyle, etc.)
> Currently the contract is very simple. Every shell script executes one (and
> only one) check and the shell response code is set according to the result
> (non-zero code if failed).
> To have better reporting in the github pr build, it would be great to improve
> the scripts to generate simple summary files and save the relevant files for
> archiving.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
