[
https://issues.apache.org/jira/browse/HDFS-14780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16917158#comment-16917158
]
Hadoop QA commented on HDFS-14780:
----------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
40s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m
4s{color} | {color:blue} The patch file was not named according to hadoop's
naming conventions. Please see https://wiki.apache.org/hadoop/HowToContribute
for instructions. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 20m
14s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
4s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
44s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
4s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
13m 2s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
6s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
53s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
54s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 38s{color} | {color:orange} hadoop-hdfs-project/hadoop-hdfs: The patch
generated 4 new + 39 unchanged - 0 fixed = 43 total (was 39) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
0s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git
apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
12m 44s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m
24s{color} | {color:red} hadoop-hdfs-project/hadoop-hdfs generated 2 new + 0
unchanged - 0 fixed = 2 total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}113m 13s{color}
| {color:red} hadoop-hdfs in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
44s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}173m 9s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-hdfs-project/hadoop-hdfs |
| |
org.apache.hadoop.hdfs.server.blockmanagement.DatanodeManager.handleHeartbeat(DatanodeRegistration,
StorageReport[], String, long, long, int, int, int, VolumeFailureSummary,
SlowPeerReports, SlowDiskReports) makes inefficient use of keySet iterator
instead of entrySet iterator At DatanodeManager.java:int, int, int,
VolumeFailureSummary, SlowPeerReports, SlowDiskReports) makes inefficient use
of keySet iterator instead of entrySet iterator At DatanodeManager.java:[line
1738] |
| |
org.apache.hadoop.hdfs.server.blockmanagement.SlowPeerTracker$ReportingNode.compareTo(SlowPeerTracker$ReportingNode)
incorrectly handles double value At SlowPeerTracker.java: At
SlowPeerTracker.java:[line 283] |
| Failed junit tests | hadoop.hdfs.TestMaintenanceState |
| | hadoop.hdfs.qjournal.server.TestJournalNodeSync |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 Image:yetus/hadoop:bdbca0e53b4 |
| JIRA Issue | HDFS-14780 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12978676/HDFS-14780 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux 7ca3438ad010 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 66cfa48 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_222 |
| findbugs | v3.1.0-RC1 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HDFS-Build/27692/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
|
| whitespace |
https://builds.apache.org/job/PreCommit-HDFS-Build/27692/artifact/out/whitespace-eol.txt
|
| findbugs |
https://builds.apache.org/job/PreCommit-HDFS-Build/27692/artifact/out/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html
|
| unit |
https://builds.apache.org/job/PreCommit-HDFS-Build/27692/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/27692/testReport/ |
| Max. process+thread count | 2659 (vs. ulimit of 5500) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs U:
hadoop-hdfs-project/hadoop-hdfs |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/27692/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> make the information of SlowPeersReport in namenode's jmx more specific
> -----------------------------------------------------------------------
>
> Key: HDFS-14780
> URL: https://issues.apache.org/jira/browse/HDFS-14780
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs
> Reporter: HaiBin Huang
> Priority: Major
> Attachments: HDFS-14780
>
>
> I found *SlowPeersReport* in namenode's jmx is too simple, so i make an
> inner class called
> org.apache.hadoop.hdfs.server.blockmanagement.SlowPeerTracker.*ReportingNode*
> to make SlowPeersReport's information more specific.Here is an example, the
> old SlowPeersReport maybe like this:
>
> {code:java}
> "SlowPeersReport"
> :[{"SlowNode":"node4","ReportingNodes":["node1"]},{"SlowNode":"node2","ReportingNodes":["node1","node3"]},{"SlowNode":"node1","ReportingNodes":["node2"]}]{code}
>
> we can see that the old SlowPeersReport just can tell you who is reporting
> the slownode, actually we can get more information by using the inner class
> *ReportingNode* :
>
> {code:java}
> "SlowPeersReport"
> :[{"SlowNode":"node4","ReportingNodes":[{"nodeId":"node1","averageDelay":2000.0,"reportTime":"Tue
> Aug 27 16:44:49 CST
> 2019"}]},{"SlowNode":"node2","ReportingNodes":[{"nodeId":"node1","averageDelay":2000.0,"reportTime":"Tue
> Aug 27 16:44:49 CST
> 2019"},{"nodeId":"node3","averageDelay":1000.0,"reportTime":"Tue Aug 27
> 16:44:49 CST
> 2019"}]},{"SlowNode":"node1","ReportingNodes":[{"nodeId":"node2","averageDelay":2000.0,"reportTime":"Tue
> Aug 27 16:44:49 CST 2019"}]}]{code}
>
> we can know the *averageDelay* of reportingnode sending packet to slownode,
> and the *reportTime* can tell us when this message reporting to namenode.I
> think these message will be helpful for us to analyze the slownode problem.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
