[
https://issues.apache.org/jira/browse/HDFS-2517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141439#comment-13141439
]
Suresh Srinivas commented on HDFS-2517:
---------------------------------------
bq. In enum NamenodeRoleProto shouldn't the first constant should start with
zero, because the corresponding java enum doesn't assign any values
I just chose the same values as defined in the java code. There is no rule to
really start an enum with zero. It is actually a constant value.
bq. StartLogSegmentResponseProto is empty, does it make sense to define an
empty proto message to be used for all void returning rpc's?
This is same as I posted in HDFS-2518, to keep StartLogSegmentResponseProto
extensible.
> Protobuf - Add protocol service for JournalProtocol
> ---------------------------------------------------
>
> Key: HDFS-2517
> URL: https://issues.apache.org/jira/browse/HDFS-2517
> Project: Hadoop HDFS
> Issue Type: New Feature
> Components: name-node
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Attachments: HDFS-2517.txt
>
>
> This jira adds protobuf service for implementing journal protocol using
> protocol buffers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
